Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Remove parent block's icon from floating toolbar #30304

Closed

Conversation

fluiddot
Copy link
Contributor

Description

Remove the icon of the parent block from the floating toolbar that is displayed when navigating inner blocks.

This change was originated while working on the reusable block feature, @iamthomasbishop mentioned that we were considering if this part is actually creating value and/or causing confusion to users.

How has this been tested?

  1. Open a post
  2. Add any block that has inner blocks (for example the Group block)
  3. Add some blocks in the Group block
  4. Select one of the inner blocks
  5. Observer that the parent icon of the parent block is not displayed.

Screenshots

Before After

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fluiddot fluiddot added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 26, 2021
@fluiddot fluiddot self-assigned this Mar 26, 2021
…ent-icon

# Conflicts:
#	packages/block-editor/src/components/block-list/block-selection-button.native.js
@youknowriad
Copy link
Contributor

Doing some cleanup to old PRs. This draft PR seems staled. Is it still relevant, should we close it?

@fluiddot
Copy link
Contributor Author

Doing some cleanup to old PRs. This draft PR seems staled. Is it still relevant, should we close it?

Yes, it's no longer relevant so I'll close it. Thanks @youknowriad for the call out 🙇 !

@fluiddot fluiddot closed this Aug 13, 2024
@fluiddot fluiddot deleted the rnmobile/update/floating-toolbar-remove-parent-icon branch August 13, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants