File block: Make the editor markup match the frontend #30148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
14 tasks
|
Size Change: -56 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Mar 23, 2021
| /> | ||
| </div> | ||
| <RichText | ||
| style={ { display: 'inline-block' } } |
There was a problem hiding this comment.
Is this preferred to using CSS?
There was a problem hiding this comment.
This one is particular, I think using CSS is favored but I preferred an inline style here because it's more explicit that this is needed for RichText to work. (It's not just a style, it's behavior in a way)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29976
RichText doesn't allow inline elements to be used as tagName, this was the reason the file block markup didn't match the frontend in the editor. It seems that we can still keep the same markup and just set an "inline-block" display style to the RichText component.
Testing Instructions
Check that the file block look the same in frontend and backend.