Block editor: focus mode: fix opacity for inner blocks, move classes #30130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Performance
ellatrix
changed the title
ellatrix
commented
Mar 23, 2021
|
Nice, this is a great improvement:
Notably the child block change is good, because before, child blocks would be faded out: This is not the case in this PR:
However there is one issue: child blocks are now extra faded out if you have no blocks selected:
|
|
Size Change: -43 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
@jasmussen Fixed the issue. :) |
|
@jasmussen Made a tiny change so that blocks that don't contain a selected block are still faded. This can be tested with the column block. Selecting a block in one column shouldn't fade in blocks in the other column. Similarly for the cover block, selecting an inner block should fade in the cover block, but only also the selected block within, not the other blocks within the cover block. Tested all kinds of blocks now and should be good. |
|
|
ellatrix
force-pushed
the
fix/focus-mode-classes
branch
from
10a6222 to
2f2ac5f
Compare
ellatrix
force-pushed
the
fix/focus-mode-classes
branch
from
2f2ac5f to
74eca5d
Compare
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one is similar to #30106. It doesn't make sense for these classes that set a mode to be added to blocks. They should be added to the block editor (wrapper). Currently,
is-focus-modeis added to every single block when focus mode is enabled.This PR moves
is-focus-modeto the root element of the block editor and takes advantage of the selected state classes to determine whether a block should be focussed or not, instead of creating a newis-focusedclass.Blocks should be faded out unless:
How has this been tested?
Test the above rules of spotlight mode. Select a block, select e.g. a cover block and select a block within the cover block.
Screenshots
Types of changes
Checklist: