Navigation: consistently provide fallback variations #30117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
commented
Mar 22, 2021
|
Size Change: +521 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
… build, add some basic tests
gwwar
force-pushed
the
fix/navigation-fallback-variations
branch
from
f5b5a36 to
ca02280
Compare
talldan
added
[Block] Navigation
talldan
approved these changes
Mar 24, 2021
|
You probably should also whitelist the file in: gutenberg/packages/block-library/package.json Lines 24 to 27 in 1d89cd9 to tell webpack that it contains side effects otherwise, tree-shaking might still trigger in the future. |
|
Thank you for figuring this one out, @gwwar! 🙌 |
|
TIL there's a whitelist for side-effects, @gziolo I can follow up 👍 |
There is a lot to learn there: https://github.com/WordPress/gutenberg/tree/trunk/packages#optimizing-for-bundlers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29984 where navigation link variations are missing in production builds.
The problem is that the following is called as a side effect of importing hooks.js in trunk. Since nothing is calling anything from hooks.js this was shaken out of the final build. This means that we saw links in our development build
npm run devbut not when usingnpm run buildProps to @kjellr for finding this.
Testing Instructions
WP 5.7
npm run buildand enable the gutenberg plugin. Note use the build and not dev command.Expected: all fallback variations appear: (link, post link, page link, category, tag)
WP Latest
npm run buildand enable the gutenberg plugin. Note use the build and not dev command.Expected: variations appear (including custom variations from plugins). Each variation has the correct icon. Note that when using custom variations, there's a new post label that plugin authors have not had a chance to add:
To see the right labels, we can edit the plugin and add
item_linkanditem_link_descriptionto the taxonomy or post-type definition.