Blocks: Adding onRemove event to verse block #30104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
ntsekouras
added
[Block] Verse
ntsekouras
approved these changes
Mar 23, 2021
|
Nice one, I'd be great to check other blocks that are based on RichText like Preformatted, Quote, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26220, adds the
onRemoveevent handler for the verse block.When testing manually, it worked as expected: when the block had no text, pressing the backspace key would remove it/merge it with the previous block - in case of a text block.
How has this been tested?
Ran
npm run testand tested the behavior manually.Types of changes
Bug fix.
Checklist: