-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the default editor font for the non FSE themes #30080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
An existing feature does not function as intended
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
labels
Mar 22, 2021
youknowriad
requested review from
scruffian,
aristath,
kjellr,
jasmussen and
carolinan
March 22, 2021 09:09
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
March 22, 2021 09:09
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ntsekouras
approved these changes
Mar 22, 2021
youknowriad
force-pushed
the
fix/default-editor-font
branch
from
March 22, 2021 10:18
9f1bd44
to
237304f
Compare
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gutenberg 10.2 we removed the default font family from themes and just relies on browser defaults and the font provided by themes. It seems that this has been too disruptive for some themes, so to avoid confusing users with this change, I'm only applying it to block themes where frontend/editor parity is a bit more important.