Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove superfluous sentence in create block tutorial #30062

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

ribaricplusplus
Copy link
Member

@ribaricplusplus ribaricplusplus commented Mar 20, 2021

Small docs change, removing an unnecessary sentence. The sentence is superfluous because it's clear that the paragraph is describing the block of code above it, and readers can see for themselves what the value of "category" is. Also the sentence uses "I" which sounds a bit weird given that many people edit these files.

Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also rewrite the sentence with I in line 5.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Mar 21, 2021
@ribaricplusplus
Copy link
Member Author

Done

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@talldan talldan merged commit a5395f8 into WordPress:trunk Mar 22, 2021
@github-actions github-actions bot added this to the Gutenberg 10.3 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants