Writing flow: remove arrow nav limitations #30057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -90 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ellatrix
commented
Mar 20, 2021
| @@ -237,6 +237,7 @@ describe( 'Quote', () => { | |||
| await page.keyboard.press( 'ArrowLeft' ); | |||
| await page.keyboard.press( 'ArrowDown' ); | |||
| await page.keyboard.press( 'ArrowDown' ); | |||
| await page.keyboard.press( 'ArrowDown' ); | |||
There was a problem hiding this comment.
Extra arrow down needed because first the block wrapper will be focused, then the content. The block wrapper is an extra navigation stop as intended.
mtias
added
the
[Feature] Writing Flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required for #30000. All focusable content must be navigable with arrow keys because Tab is meant to navigate in and out of the content (single tab stop).
I'm not sure why we ever imposed these limitations. When navigating with arrow keys, non text fields should be navigable too, which is similar to TinyMCE and CKEditor "objects". I don't see any good reason to limit this.
Code-wise this also removes some complexity, which wasn't even e2e tested. Surprisingly, removing the code doesn't trigger any but one e2e test failures.
How has this been tested?
This will only affect blocks that contain multiple fields. E.g. The block wrapper for an image, quote or table block will now be navigable with arrow keys and add an extra step.
Screenshots
Types of changes
Checklist: