Add possibility to position help text below the label of CheckboxControl component #30025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzim
added
[Feature] UI Components
|
Size Change: +134 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
7 tasks
|
Thanks for working on this @grzim. I think this does need more design feedback, so it's good that you added the label. We really need to consider how this looks alongside other controls. The design in #28864 is inconsistent with how ToggleControl looks when shown in a block inspector (see the paragraph block). The problem here might be that ToggleControl is wrong as well. ToggleControl: The proposed CheckboxControl style: They don't look right when used together. Ultimately we should just be able to drop these components in and have the look the same. I'd vote for not having a As an aside, ToggleControl does have a similar styling discrepancy, this is how it looks in the editor settings dialog: |
draganescu
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #30023
Adds a property
helpPositiontoCheckboxControlallowing to change the place wherehelpis rendered, allowing to display the text under the label (as it is proposed in a design for #29458).The property is set to
leftby default which means to render help text the same as it used to be.Broken CheckboxControl header addressed in a separate PR #30037
How has this been tested?
In order to test a component, please see
/story/components-checkboxcontrol--allin the storybookScreenshots
Types of changes
New feature added to the
CheckboxControlcomponentChecklist: