-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Tests: Cover the case when using multiple words in the inserter #29978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] E2E Tests
/packages/e2e-tests
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
labels
Mar 18, 2021
gziolo
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Mar 18, 2021
gziolo
commented
Mar 18, 2021
@@ -372,4 +386,39 @@ describe( 'adding blocks', () => { | |||
); | |||
expect( isFocusInBlock ).toBe( true ); | |||
} ); | |||
|
|||
it( 'shows block preview when hovering over block in inserter', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next two tests are moved from inserter.test.js
.
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
gziolo
changed the title
Add/e2e test slash inserter multiple words
E2E Tests: Cover the case when using multiple words in the inserter
Mar 18, 2021
7 tasks
youknowriad
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool, I like the consolidation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Package] E2E Tests
/packages/e2e-tests
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #29939.
This PR adds e2e test that covers the case when two words are used to insert the block with the slash inserter.
I had some issues finding the spec that covers inserting block so I decided to consolidate existing tests under
inserting-blocks.test.js
.How has this been tested?
See the e2e test added.
Types of changes
Checklist: