Allow themes to use any styles in the theme.json whether or not the block supports it #29941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Feature] Themes
|
Size Change: +1.56 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
It works and it's brilliant and I'm walking on sunshine. |
This was referenced Mar 17, 2021
|
@nosolosw, can you provide a more detailed description of what has changed with this PR? I'm having a hard time understanding how it impacts a single block. In particular, I'd be interested in seeing how it impacts |
|
@gziolo expanded a bit on the "changes in this PR" section, does that help? In terms of block.json, nothing changes. In terms of theme.json, the noticeable change is what I shared in the test instructions: that themes can know use style properties in the theme.json in blocks that don't declare support for them (ex: use a font-family for paragraphs despite the block doesn't declare support for font families). |
|
Thanks, @nosolosw. I think I get it now 😄 Code changes look good, I would appreciate some validation from other folks that know better how it works in practice. |
gziolo
approved these changes
Mar 18, 2021
|
I think this is not only the right direction but also simplifies the codebase quite a bit |
|
@mtias, and the efforts required to keep the documentation up to date, instead we have this really nice sentence:
|
gziolo
reviewed
Mar 18, 2021
Co-authored-by: Greg Ziółkowski <[email protected]>
aristath
approved these changes
Mar 18, 2021
oandregal
deleted the
update/disconnect-block-json-and-theme-json-styles
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #29778 (comment)
With this PR, block supports are no longer used to decide whether the styles in the theme.json for a block should be used or not. Block supports are still used to show UI controls in both the block & global styles sidebar (themes can use any style property, users can use use the style properties "supported" by the block).
Changes in this PR:
Server:
Client:
Update theme.json docs accordingly.
How to test
Make sure existing themes work as expected: using TT1-blocks go to the site editor and load the front-end. Verify they work as expected.
Make sure themes can use any style property in the theme.json file:
Before this change, the font-family for the paragraph will be ignored.