Navigation Link: Match Editor Markup to Rendered #29935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +24 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
@jasmussen is it okay that the richtext/textarea is a div instead of span? |
Let me give it a quick spin. I take it the span can't be editable? |
|
So I think I found a few existing accessibility issues while testing with voiceover. If we'd like to tackle this in separate issues, let me know and I can file new tickets. For folks 👀 , also let me know if certain behavior is expected or if there's alternative keyboard movement controls. (I am aware of keyboard shortcuts, though any richtext or text areas will capture keyboard input).
Navigation doesn't appear to be selected, I need to tab again. emptyfocus.mp4
a11y.mp4Other keyboard shortcuts for reference. |
|
From a quick test, this looks amazing. Before in the editor:
After in the editor:
The frontend looks the same:
Note, the above is the page list and a custom menu item, and I'm testing using "empty theme": https://github.com/WordPress/theme-experiments. The custom menu item does not have an underline, but that appears to be due to this CSS from #26059: Testing my own theme, which styles the a with a box shadow, here's before:
and here's after:
And after is what it's supposed to look like:
In other words, this is working, and the fact that it surfaces that text-decoration rule is an example of why this one is so important to land, because otherwise the CSS we write won't be able to easily affect both the Page List block, custom menu items, and the frontend at the same time, needing 3 separate rulesets. This is being reduced to one ruleset, which is just 👌 Kerry about the keyboard interaction, in some contexts we use tab to switch region or section, and arrowkeys to navigate items within. That may be what's going on here. But just for this PR specifically, I'd compare with what's in trunk. There's certainly still some things we need to get right here, but just important we know whether they're tied to this PR or not. |
|
🎉 |
|
Here's the a11y issue I filed: #29948 |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #28575
Changes the element structure of the navigation link block in the editor to match the rendered output.
Editor markup:
Rendered markup:
How has this been tested?
Manually tested on desktop Firefox
Screenshots
Checklist: