Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Title: Add link color option #29924

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Mar 17, 2021

Description

Fixes #29650

The Site Title block is always a link. This PR adds the link color option, and disables the text color option.

How has this been tested?

Tested manually by adding the Site Title block in TT1 Blocks and confirming that the link colors work.

Types of changes

Bug Fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Site Editing: Site title block color setting not working properly
3 participants