Limit number of items to 1 if selecting the option to use query from query string #29915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +37 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
vindl
reviewed
Mar 17, 2021
Thanks for pointing this out, just pushed a fix for this. |
glendaviesnz
changed the title
but still failing in CI, will take another look. |
glendaviesnz
force-pushed
the
update/query-block-url-query
branch
from
1c09f8f
to
e3833a5
Compare
|
Limiting the number to 1 is not the proper solution here I think. The goal would be to show the number of posts from Currently there is a specific setting in In general we need to find a way to detect the context a Query lives (page/archive) and set the |
Thanks for the feedback @ntsekouras, I am going to close this for now then, and look for another approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #29438
Description
Currently when selecting
Inherit query from urlthe query loop block still shows the default number of posts fromgetSettings().postsPerPageorDEFAULTS_POSTS_PER_PAGEwhich means the editor doesn't match the frontend where a single post/page is likely to display.How has this been tested?
Just manually currently
Types of changes
If
Inherit query from urlis toggled on sets the posts per page to 1 in order to better match what is shown in the editor to what you see in from end.Testing
Checkout PR to local dev env
Enable FSE theme
In FSE editor edit page template and add a Query block
Toggle
Inherit query from urlon and make sure only one page/posts displays in front end and editorToggle
Inherit query from urloff and make sure the default number of posts per page displays in editor and frontendChecklist: