Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent PanelBody title from being overlapped by arrow #29914

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

MatzeKitt
Copy link
Contributor

Description

This will fix #29913.

How has this been tested?

  • Checked the updated style in Safari, Chrome and Firefox.

Types of changes

Non-breaking styling fix for PanelBody title area.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 16, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @MatzeKitt! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added [Package] Components /packages/components [Type] Bug An existing feature does not function as intended labels Mar 17, 2021
@talldan talldan changed the base branch from master to trunk March 17, 2021 01:06
@talldan
Copy link
Contributor

talldan commented Mar 17, 2021

Thanks for working on this @MatzeKitt.

Gutenberg now uses trunk as its main branch, so I've switched the base branch in the PR. There are some failing tests because of an issue with the docker environment, bit this has been fixed in a commit to trunk. Would you be able to rebase your branch on top of trunk to get the tests passing? (git pull --rebase origin trunk should do the trick).

@MatzeKitt
Copy link
Contributor Author

@talldan Yes, I will try! Thank you for the information.

@@ -77,6 +77,7 @@
.components-panel__body-toggle.components-button {
position: relative;
padding: $grid-unit-20;
padding-right: 48px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @MatzeKitt !

I think you should make your change in the above padding rule. Also it's better to use GB declared variables.
$grid-unit-60 equals 48px.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my pull request accordingly. 🙂

@ntsekouras ntsekouras requested a review from jasmussen March 17, 2021 12:46
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks @MatzeKitt.

@talldan talldan merged commit e27f190 into WordPress:trunk Mar 18, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @MatzeKitt! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@ntsekouras
Copy link
Contributor

Congrats on your first contribution in GB @MatzeKitt ! 🎉 Thank you!

@MatzeKitt
Copy link
Contributor Author

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelBody arrow may overlap its title
3 participants