-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent PanelBody title from being overlapped by arrow #29914
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @MatzeKitt! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for working on this @MatzeKitt. Gutenberg now uses |
@talldan Yes, I will try! Thank you for the information. |
@@ -77,6 +77,7 @@ | |||
.components-panel__body-toggle.components-button { | |||
position: relative; | |||
padding: $grid-unit-20; | |||
padding-right: 48px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @MatzeKitt !
I think you should make your change in the above padding
rule. Also it's better to use GB declared variables.
$grid-unit-60
equals 48px
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my pull request accordingly. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, thanks @MatzeKitt.
Congratulations on your first merged pull request, @MatzeKitt! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Congrats on your first contribution in GB @MatzeKitt ! 🎉 Thank you! |
Thank you! 🙂 |
Description
This will fix #29913.
How has this been tested?
Types of changes
Non-breaking styling fix for PanelBody title area.
Checklist: