-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Editor: Improve default label of location select #29908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
March 16, 2021 18:43
The size of this thing is not optimal but we;re updating the location of the menu location in #29458 |
Size Change: +15 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚢
talldan
changed the title
Improve default label of location select
Navigation Editor: Improve default label of location select
Mar 17, 2021
talldan
added
[Feature] Navigation Screen
[Type] Enhancement
A suggestion for improvement.
labels
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #25313
This PR copies the same label used in the classic navigation editor for the assign location select default optionn.
How has this been tested?
Screenshots
Types of changes
String fixed.
Checklist: