Navigation Editor: Show all menus in manage locations #29906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
talldan
changed the title
talldan
added
[Feature] Navigation Screen
[Type] Bug
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28933.
The Menu Locations dropdown in the Navigation editor was showing only 10 items because it was doing it's own API call to get the list of menus.
This PR fixes this and reuses the menus got by the navigation editor itself.
How has this been tested?
Tested locally.
To test:
Screenshots
Types of changes
Non breaking bug fix.
Checklist: