Polish site button focus/hover styles in post and site editor #29888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
jasmussen
changed the title
|
Size Change: +308 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
polish/focus-styles
branch
from
fa9b9e3 to
6d29467
Compare
mtias
approved these changes
Mar 18, 2021
This was referenced Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup to #29872. I had forgotten that a lot of the structural CSS is duplicated between post and site editors, as opposed to being reused.
This PR brings the new focus styles to the site editor as well.
It also polished a small border radius, and adds a hover state:
How has this been tested?
Hover and focus the site button in the post editor. Do the same in the site editor.
Checklist: