RichText: remove dead and deprecated setFocusedElement #29877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -115 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
remove/deprecated-set-focussed-element
branch
from
018db71 to
a17d4ec
Compare
ellatrix
force-pushed
the
remove/deprecated-set-focussed-element
branch
from
a17d4ec to
a3807e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was deprecated in #17421.
This code no longer runs since the props is no longer passed down to the internal RichText component since #23034.
No one has complained so far it seems, and if a plugin still needs it even though it's not been working for a while, they should probably use
unstableOnFocusor check the block editor store for selection information.Reduces some maintenance headaches.
How has this been tested?
Screenshots
Types of changes
Checklist: