Try: Fix gallery item clicking. #29860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Editing options are now usable 👍 But how to cancel the editing mode? the first impression was clicking again on the pencil icon might toggle the edit mode |
|
Thanks for testing!
I think that's a separate issue, and it might not be worth fixing since the gallery is being refactored to use innerblocks soon. |
|
Hey Joen I just tested the PR. Upload, Media Library and Insert from URL now works. Pattern-Gallery-edit-image-buttons-fixed.mp4I have also tested with switching out the images. Adding additional images. The buttons work as they should. |
youknowriad
approved these changes
Mar 18, 2021
youknowriad
added
the
Backport to WP Minor Release
6 tasks
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
noisysocks
removed
the
Backport to WP Minor Release
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29835.
I have not had time to test this thoroughly, so I'd appreciate sanity checks and tests of edgecases this might introduce.
Checklist: