Site Editor: close navigation panel after template selection #29806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
creativecoder
requested review from
vindl,
jeyip,
mattwiebe,
david-szabo97,
Copons and
Addison-Stavlo
- Use separate tests database service - Configure database credentials in every service - Set wp-config.php to be writable Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Noah Allen <[email protected]>
|
Note I cherry-picked f8052e1 to try and get e2e tests passing in CI. There is still a (seemingly unrelated) navigation editor test failing... will wait until #29762 is updated against trunk, then try rebasing this branch. (cc @david-szabo97 ) |
david-szabo97
force-pushed
the
fix/reduce-motion-override-delay-too
branch
from
43ebb01 to
9d9def4
Compare
|
Note that I'm not able to reopen this PR to update the base branch to trunk, so I've opened #29956 instead, after rebasing from trunk. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically closes the navigation panel within the site editor after selecting a template or content item.
Follow-up to #29489: it's particularly helpful on smaller screens, where you would otherwise be left with the navigation panel taking up most of the screen after making a selection.
Based off of #29762, which is required for e2e tests to pass.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: