Add loginout block #29766
Merged
Add loginout block #29766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
requested review from
ajitbohra,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
aristath
added
[Feature] Blocks
|
Size Change: +561 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Co-authored-by: Timothy Jacobs <[email protected]>
carolinan
reviewed
Mar 16, 2021
carolinan
reviewed
Mar 16, 2021
|
In a future version it may be a good idea to add an option to display the username/display name of the person who is logged in, |
|
Could you add some screenshots on how it's displaying? |
|
In TT1 Blocks Editor: Front, one of each setting:
|
ntsekouras
reviewed
Mar 17, 2021
|
The CSS classes are working now. Can someone confirm if the login form works when "Redirect to current URL" is not enabled? |
ntsekouras
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Thanks for working on this Ari!
I tested and works as expected. I've left some comments and even though the text is not editable, it can be with the loginout filter: https://developer.wordpress.org/reference/hooks/loginout/, so I think it's okay for start.
@carolinan it worked for me. |
I was able to replicate the issue, fixed in f4d2090 👍 |
|
Now the block always redirect to the current URL, no matter if the option is enabled or not? |
The login form is embedded in the page, so it's not a redirection... That is the default behavior so it doesn't change. |
ntsekouras
reviewed
Mar 17, 2021
ntsekouras
approved these changes
Mar 18, 2021
ntsekouras
reviewed
Mar 18, 2021
|
Thank you everyone who helped with feedback 👍 |
|
Do we have something similar for editing posts and pages? I mean the |
|
There was a discussion about not supporting the Edit links. They can be awkward to work with since they are only visible for users with edit capabilities. The admin bar also has an edit flow. |
gziolo
reviewed
Mar 18, 2021
gziolo
reviewed
Mar 18, 2021
gziolo
reviewed
Mar 18, 2021
|
@aristath, nice work on this PR. I left some comments regarding the block naming that could benefit from some polishing.
I guess I got used to editing the post from the list of posts on the home page. It's probably fine to do one more click 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a login/out block, part of #22724
Options for the block:
Checklist: