Fix React warning in Text Control #29724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
gziolo
added
the
Good First Review
|
Size Change: -5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
dcalhoun
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
LGTM. I verified the branch works as expected for both web and native.
I agree that renaming valuePlaceholder to placeholder makes sense and would potentially help avoid this issue from resurfacing in the future. I placed it on my todo list to explore.
Thank you for taking the time to create a fix for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing another PR, I noticed this bug that was causing a React warning:
React does not recognize thevaluePlaceholderprop on a DOM element.. This was introduced here: #27935I would suggest mobile app team to create a follow up with renaming
valuePlaceholdertoplaceholderfor native files, if it makes sense.Testing instructions
You have to open the console output in your browser.
Buttonsblock and then select a singleButton.Inspector controlsopen theAdvancedpanelIn this PR repeat the above steps and observe that no error is thrown.
Checklist: