-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media & Text: Allow drag n drop media replacement #29710
Media & Text: Allow drag n drop media replacement #29710
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Mamaduka! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Howdy @Mamaduka and welcome! Thank you for contributing. I tested this PR and it does work, but it would be great if the block would show something is happening upon drag. Here is a video comparing to how the image block handles drag and drop: dropmediatext.mp4 |
Thanks, @draganescu for testing the PR. 100% with you about the upload indicator. I'm reusing the |
fa206d3
to
b4033b3
Compare
Hi, @draganescu After thinking more about this, it makes sense to include Spinner change as a part of this PR. See b4033b3. |
b4033b3
to
631a2d9
Compare
631a2d9
to
79f262f
Compare
Hi, @draganescu Is it possible to get another review on this PR? 🙇 |
Sorry about the delay on this one. In fact the branch was so old I had to rebase it in order to compile it 🙈 You can always feel free to request a review from me in the future if you get stalled. Here's before: Here's after: Very nice. It could use a code sanity check, and I'd recommend giving it a good rebase first. But giving it a green check for the experience. Excellent work. |
79f262f
to
a65cbf2
Compare
Thanks for the review, @jasmussen. Rebased and will merge once all checks are green 🤞 |
Thanks for chiming in @jasmussen and sorry for not following up @Mamaduka! Nevertheless 🎉 great work! |
Description
Adds dropzone to the media part of the block when an image/video is already set. Fixes #26320.
How has this been tested?
Manually on local dev environment.
Steps:
Types of changes
New feature
Checklist: