-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Try fixing split/merge issue on native mobile by dropping selection update event when late #29683
Merged
hypest
merged 12 commits into
trunk
from
rnmobile/try-fix-split-issue-drop-selection-update-event
Mar 18, 2021
Merged
[RNMobile] Try fixing split/merge issue on native mobile by dropping selection update event when late #29683
hypest
merged 12 commits into
trunk
from
rnmobile/try-fix-split-issue-drop-selection-update-event
Mar 18, 2021
Commits on Mar 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1a926f5 - Browse repository at this point
Copy the full SHA 1a926f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d78ea4b - Browse repository at this point
Copy the full SHA d78ea4bView commit details
Commits on Mar 10, 2021
-
Sync native mobile event counter to the JS side one
This way, when the JS bumps the counter, the native side picks it up and increments from there.
Configuration menu - View commit details
-
Copy full SHA for b20609c - Browse repository at this point
Copy the full SHA b20609cView commit details
Commits on Mar 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 35dc09b - Browse repository at this point
Copy the full SHA 35dc09bView commit details -
Introducing shouldDropEventFromAztec and using it in onChange too
So to drop the Aztec onChange events too, if late.
Configuration menu - View commit details
-
Copy full SHA for 506cb27 - Browse repository at this point
Copy the full SHA 506cb27View commit details -
Don't bump the local event counter on componentDidUpdate
If the update was due to content change from the JS side of things, the counter would have already been bumped in shouldComponentUpdate (hopefully), so bumping it again in DidUpdate introduces a counter bump that gets out-of-sync with Aztec since (the bump inside DidUpdate doesn't cause a render and thus no new counter sent to Aztec).
Configuration menu - View commit details
-
Copy full SHA for 629d81f - Browse repository at this point
Copy the full SHA 629d81fView commit details
Commits on Mar 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ede2d82 - Browse repository at this point
Copy the full SHA ede2d82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a32a01 - Browse repository at this point
Copy the full SHA 4a32a01View commit details
Commits on Mar 18, 2021
-
Co-authored-by: Joel Dean <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef8d922 - Browse repository at this point
Copy the full SHA ef8d922View commit details -
Configuration menu - View commit details
-
Copy full SHA for 016201d - Browse repository at this point
Copy the full SHA 016201dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21024ff - Browse repository at this point
Copy the full SHA 21024ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fef783 - Browse repository at this point
Copy the full SHA 3fef783View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.