Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Try fixing split/merge issue on native mobile by dropping selection update event when late #29683

Merged
merged 12 commits into from
Mar 18, 2021
Merged

[RNMobile] Try fixing split/merge issue on native mobile by dropping selection update event when late #29683

merged 12 commits into from
Mar 18, 2021

Commits on Mar 9, 2021

  1. Bump native event count and drop selection update event if late

    @hypest
    hypest committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    1a926f5 View commit details
    Browse the repository at this point in the history

  2. Limit the event count bump and event dropping to iOS

    @hypest
    hypest committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d78ea4b View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Sync native mobile event counter to the JS side one 

    This way, when the JS bumps the counter, the native side picks it up and
increments from there.
    @hypest
    hypest committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b20609c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. More usage of event counter bumping instead of undefining

    @hypest
    hypest committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    35dc09b View commit details
    Browse the repository at this point in the history

  2. Introducing shouldDropEventFromAztec and using it in onChange too 

    So to drop the Aztec onChange events too, if late.
    @hypest
    hypest committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    506cb27 View commit details
    Browse the repository at this point in the history

  3. Don't bump the local event counter on componentDidUpdate 

    If the update was due to content change from the JS side of things, the
counter would have already been bumped in shouldComponentUpdate
(hopefully), so bumping it again in DidUpdate introduces a counter bump
that gets out-of-sync with Aztec since (the bump inside DidUpdate
doesn't cause a render and thus no new counter sent to Aztec).
    @hypest
    hypest committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    629d81f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Merge branch 'trunk' into rnmobile/try-fix-split-issue-drop-selection… 

    …-update-event
    @hypest
    hypest committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    ede2d82 View commit details
    Browse the repository at this point in the history

  2. Use window.console, to satisfy linter

    @hypest
    hypest committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    4a32a01 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Fix typo in comments 

    Co-authored-by: Joel Dean <[email protected]>
    @hypest @jd-alexander
    hypest and jd-alexander authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ef8d922 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/try-fix-split-issue-drop-selection… 

    …-update-event
    @hypest
    hypest committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    016201d View commit details
    Browse the repository at this point in the history

  3. Sync changelog instructions for native mobile

    @hypest
    hypest committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    21024ff View commit details
    Browse the repository at this point in the history

  4. Changelog entry for the split/merge regression fix

    @hypest
    hypest committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    3fef783 View commit details
    Browse the repository at this point in the history