Fix broken links to the block editor developer handbook #29663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
requested review from
ajitbohra,
chrisvanpatten and
gziolo
as code owners
|
Size Change: -387 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
@JustinyAhin I think the newly added page for Block Variations is now also missing from the handbook - #29515 At least I couldn't see it (cc @ntsekouras) |
I just added it in c064acf |
Rename /contributors/code/getting-started to /contributors/code/getting-started-with-code-contribution. This is done to avoid having two handbook pages with the same slug, because this results in some confusion when the pages are generated. Also, replace all the occurence of the first with the second.
|
If you look at the homepage, you’ll see these two "Getting Started"
It is a bit weird because the first lines of toc.json (https://github.com/WordPress/gutenberg/blob/trunk/docs/toc.json#L2) say there should be an only one "Getting Started" page with "Tutorials" as subfolder and I assume this is duplicated because there is another page with the same slug. I tried to fix it in 93e92af. cc @mkaz do you have any idea/input about this? |
|
The first getting started is from the title of the The second Getting Started is the section from: |
Ok, i think I get it now. Thanks :) |
|
@mkaz per your comment https://wordpress.slack.com/archives/C02QB2JS7/p1615307264011000?thread_ts=1615289099.009500&cid=C02QB2JS7 So this means we'll end up with a structure like So we get rid of the Getting Started (https://developer.wordpress.org/block-editor/getting-started/) folder. Am I right? |
|
@JustinyAhin yes, that is what I was thinking if that works. I wasn't sure about Reference or Explanations, I think I do like it in Explanations better (how you have it) since I think of Reference more as API Reference. There are some weird issues sometimes when documents have the same name, I'm not sure if that is what is causing it or the root cause of why things get weird sometimes. I think it has to do with it published to WP pages and if the URL is not quite right WordPress will do an internal lookup and find the page. But I'm not positive what is happening in this case, sometimes easiest to have different names 😁 |
mkaz
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Thanks for finding and fixing the links 👍
Let's merge these in, since its a good first pass and we can continue to find additional and update as we go.
Thanks for tackling the reorg issue, I've wanted to do it for awhile but knew it would be messy and didn't quite have the courage to do so. So appreciate you "ripping the band-aid off" and getting the update. out.
|
Thanks for handling this!
I didn't see the link for block variations here: https://developer.wordpress.org/block-editor/reference-guides/block-api/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29662.