Make the lists more wysiwyg #29556
Closed
Make the lists more wysiwyg #29556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
scruffian,
aristath,
kjellr,
jasmussen and
carolinan
|
Depending how impactful is this PR, we could decide to remove some of the opinionated styles or move them to "theme.scss" instead of "style.scss". |
|
I love these PRs, and I love that we're at a place where we can put everything in its right place. Those editor styles you can likely remove once the iframe lands 👌 However, something's off. This is what I see in trunk:
This is what I see in this branch:
|
|
Size Change: +6.94 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
@jasmussen I suspect that your build didn't refresh the blocks stylesheet. I can't reproduce your issue on 2020 |
|
I'm still seeing it after running
|
|
I see the same thing as @jasmussen. Would it be possible to enqueue the block library CSS after the wp-admin CSS? |
|
Just discovered this:
Which is an excellent example of why the work you're doing here is so important 💯 (The above is not broken in trunk) |
|
I fixed that sidebar tabs bug. I'm still not able to reproduce the issue for the "common.css" style override personally, I think maybe the order of the stylesheet is inconsistent depending on other factors. So for the moment, I restored the editor styles for "ul" which should have a higher specificity, this is something that can be removed once we iframe the post editor. |
|
I'm closing this in favor or #29590 |
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #29517
When using lists in a theme without any stylesheet, the result in the frontend is different than the result in the backend, the problem is that in the backend there are default styles for lists. In order to solve this, we have two options:
I thought that the editor styles applied were better defaults for lists than what comes with the browser so I went with the second option. That said, it's the most impactful option, but I think most themes already override these styles in their stylesheets so it might not be that impactful.
What do you think?
Testing instructions