Remove base control negative help text margin #29550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
Size Change: +6.73 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Yes please! This has been driving me batty ❤️ |
chrisvanpatten
approved these changes
Mar 4, 2021
|
I'm also removing the unused SCSS file, as base control use css in js now (convo here - #25842 (comment)) |
This was referenced Jun 7, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #29012 (comment), @shaunandrews noticed that help text for the BaseControl component looks uncomfortably close to the input itself. In the navigation editor it looks like this:
There's some negative margin causing the help text not to social distance from the input.
In the post editor, it generally looks like this:
Negative margin isn't applied in the sidebar because of this non-BEM CSS that styles every sidebar paragraph:
Seems like an inconsistency. This PR removes negative margin from BaseControl so that the navigation editor looks consistent.
How has this been tested?
Screenshots
Types of changes
Minor breaking CSS change.
Checklist: