Fix specificity issue between theme and user styles #29533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
20 tasks
|
Size Change: +194 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 3, 2021
oandregal
force-pushed
the
fix/specificity-user-styles
branch
from
31d613b to
e5a92b6
Compare
Given how the style system works, !important is a good choice for preset classes the user attaches to the post content. If those values need to be overridden, in addition to regular CSS, we can offer hooks for the theme.json processing, so plugins have an alternate mechanism to modify this behavior.
oandregal
force-pushed
the
fix/specificity-user-styles
branch
from
e5a92b6 to
980a0b6
Compare
youknowriad
approved these changes
Mar 4, 2021
aristath
approved these changes
Mar 4, 2021
|
OK, I think I'm going to land this so we can get better feedback ― this is something that's easily reversible so we can course-correct later, if necessary. |
|
Wanted to share #29985 (comment) for all that follow this PR. |
This was referenced Jan 27, 2022
|
Hi guys, I'm very late to the party, but the issue with From your conversation above:
There may be potentially a big issue with Gutenberg not applying "BEMish" naming on modifier CSS classes. Although it uses BEM for block classes (such as It is especially impossible to target If Gutenberg used BEMish naming for modifier classes such as Also, there is no way for theme authors to know about potential redundancy of It seems like there is no documentation for Gutenberg best practices and standards so even extension plugins can follow these to make the ecosystem more consistent. (→ could be of an interest for @annezazu re dev focused communication site) It's also confusing that colors have a helper class ( But like I've mentioned, this issue could be resolved with more modular naming of CSS classes. Do you think it is worth to log a new issue ticket for this problem? |
|
Hey Oliver. Sure, if there's an issue with how current classes work that merits an independent conversation. |
|
Hi André, There is actually no issue currently with the classes. I will open a new issue for discussion. Thanks. |
|
Hi Oliver, if there's no current issue but you still want to share your thoughts on something, I believe https://github.com/WordPress/gutenberg/discussions would be a better place as it helps keep Gutenberg issues for triaging actual product bugs/features/etc. |
|
Thanks for pointing me in the right direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29381
How to test
The expected behavior would be that the user choices are respected, both in the editor and front-end.