[Query block] Remove exclusion of current page id #29432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: -48 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
@ntsekouras code changes here look reasonable, were there any suggested manual testing instructions? |
I just updated the PR's description. -- @gwwar |
aristath
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the exclusion of the current
postIdinQueryblock. That was a premature and early addition that is wrong, but aimed to handle some infinite recursion problems if we includedpost-contentinto itself.This should be handled with the new hook introduced here: #28428 probably, and will be in a follow up.
Testing Instructions
Just insert a Query block and verify it works as before.
The only exception would be the crashing of the editor if you insert a Query in a post/page and include
Post Contentin the loop and include the same page/post you are editing in the results. I wouldn't recommend to try that though :)