-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel Preset: Add wiring necessary to integrate Fast Refresh into bundlers #29419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] Babel preset
/packages/babel-preset-default
[Type] New API
New API to be used by plugin developers or package users.
labels
Mar 1, 2021
gziolo
force-pushed
the
update/babel-rect-refresh
branch
from
March 1, 2021 07:23
a31592a
to
6b43c9d
Compare
Size Change: +49.6 kB (+4%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
It looks like Babel env is set to development by default when running Babel to build WordPress packages. I think this Babel helper makes only sense as part of Webpack processing. I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Tool] Babel preset
/packages/babel-preset-default
[Type] New API
New API to be used by plugin developers or package users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #28273.
Adds
react-refresh/babel
that implements the wiring necessary to integrate Fast Refresh into bundlers. More details at https://github.com/pmmmwh/react-refresh-webpack-plugin. This change allows 3rd party project to simplify their integration with React Fast Refresh.Testing
Make sure that CI jobs still pass. In the future, it will be retested in #28273. For now, I can confirm that it worked in my tests as advertised.
Types of changes
New feature (non-breaking change which adds functionality).
Checklist: