Remove class= wrapper to already wrapped attributes. Issue #29209 #29214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I attached a screen capture for the block with the fix applied to the original issue #29209 |
jorgefilipecosta
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
This issue was already fixed in #30056, but I'm merging this PR anyway to also give credit to @bobbingwide given that this PR was opened first :) Thank you for working on this Fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've changed the server side rendering of the core/post-comments-count block, removing the unnecessary "class=" wrapper to the attributes for the
<div>tag for the block.How has this been tested?
I pre-tested tested the fix locally by changing the run time file.
Screenshots
Types of changes
Fixes #29209
Checklist: