-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Upgrade to RN 0.64 #29118
Merged
Merged
Changes from 245 commits
Commits
Show all changes
251 commits
Select commit
Hold shift + click to select a range
931d033
Make sure that _input exists.
SergioEstevao ebfca1d
Fix HtmlTextInput tests.
SergioEstevao 06a3ec5
Fix TextInput mock.
SergioEstevao 14deabf
fix lint errors
marecar3 dd12e0f
Bump rn to 0.62.2
marecar3 f67d117
Remove hack as PR fix: https://github.com/facebook/react-native/pull/…
marecar3 eda1b1d
[iOS] Use react native 0.62 hook for dark mode (#21455)
marecar3 19b4f3b
Bump react to 16.11.0
marecar3 433bb17
Use correct version of react and react-dom
marecar3 8d35244
Framework: Update package-lock.json
aduth 1bc80bd
Update package-lock.json
marecar3 08c617d
fix package.json
marecar3 926253f
Apply local changes to package-lock.json
gziolo 885fbe9
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 e26e8d4
Update license checker
marecar3 95af74d
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 1e0e194
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 822f0c0
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 01bd36f
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 f7eb39b
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 7ae6244
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 431506b
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 b30fe76
Merge
marecar3 fe43e8a
Merge branch 'master' into rnmobile/update-rn-0-62
marecar3 eda1828
Merge branch 'master' into rnmobile/update-rn-0-62
SergioEstevao 0c9067b
Update packages to use RN version 0.62.2
SergioEstevao c33d823
Merge branch 'master' into rnmobile/update-rn-0-62
SergioEstevao 4755944
Update project locks.
SergioEstevao 90b9afc
Merge branch 'master' into rnmobile/update-rn-0-62
SergioEstevao e7bcce6
Match babel-preset between react-native-editor and gutenberg packages.
SergioEstevao a314c66
Update lock file.
SergioEstevao 8b10a7c
Merge branch 'master' into rnmobile/update-rn-0-62
SergioEstevao 4b750ff
Fix package number.
SergioEstevao 11d6bdf
Update podfile.lock
SergioEstevao 6d0d68d
Merge branch 'master' into rnmobile/update-rn-0-63
ceyhun 177fb5f
Update react-native-svg and react-native-video refs
ceyhun a35f7e4
Update react-native patch to 0.62.2
ceyhun 2c01a36
Upgrade react-native and related packages
ceyhun 0db027d
Update pods
ceyhun a5ae76d
Add back metro-react-native-babel-transformer
ceyhun 83387e8
Update react-native-keyboard-aware-scroll-view ref
ceyhun bb50bd3
Update RN version in build.gradle
ceyhun e4b4b62
Hoist `jsc-android` to top-level node_modules folder
ceyhun 400cd87
Remove metro patch that's no longer needed
ceyhun ef1774e
Remove flex-wrap from contentContainerStyle of KeyboardAwareFlatList
ceyhun d401688
Use correct key prop in picker render method
ceyhun 47bd771
Use native ref instead of tag to focus and blur
ceyhun ace6218
Replace deprecated currentlyFocusedField with currentlyFocusedInput
ceyhun e001635
Update react-native-keyboard-aware-scroll-view ref
ceyhun 9cc76b2
Revert "Replace deprecated currentlyFocusedField with currentlyFocuse…
ceyhun f1c73a1
Revert "Use native ref instead of tag to focus and blur"
ceyhun f0ea684
Use old implementation of TextInputState in AztecView
ceyhun 6ef5d55
Remove RN 0.62 patch
ceyhun d2c116e
Add RN 0.63 patch
ceyhun 9c76876
Revert "Use old implementation of TextInputState in AztecView"
ceyhun bf4cb7c
Merge branch 'master' into rnmobile/update-rn-0-63
ceyhun 9f68572
Merge branch 'master' into rnmobile/update-rn-0-63
ceyhun aabd2b2
Hoist jsc-android to top-level node_modules folder again after mergin…
ceyhun a84ba59
Update cli-platform-ios path
ceyhun 445bab8
Fix iOS focus/blur crashes via implementing them in native and using …
ceyhun b7f9db5
Use ref instead of innerRef for react-native-keyboard-aware-scroll-view
ceyhun 58c933c
Merge branch 'master' into rnmobile/update-rn-0-63
ceyhun 7b69f29
Update package-lock.json
ceyhun 10e24f4
Fix bundle commands
ceyhun 50565ba
Update Podfile.lock
ceyhun 9f89349
Update unit test snapshot
ceyhun 6e32bf9
Fix iOS build cache hit test
ceyhun 96c11e9
Bust iOS build cache
ceyhun 7e8136a
Revert "Bust iOS build cache"
ceyhun f4bda02
Merge branch 'master' into rnmobile/update-rn-0-63
ceyhun bad6c8a
Bust iOS build cache
ceyhun c869c2b
Fix hermes CLI name
ceyhun e141e92
Remove iOS build cache
ceyhun 8bd1bda
Update package-lock.json
ceyhun ed3058b
Update remaining android files from 0.63 diff
ceyhun 81ebb95
Fix android focus/blur issues
ceyhun 8eb21bb
Replace deprecated currentlyFocusedField
cameronvoell 51a24e5
Prevents immediate crash on physical android devices
cameronvoell 826c318
update deps
dratwas aebcf82
merge with master
dratwas 4598381
update dependencies
dratwas 4c36e39
update dependencies in react-native-editor
dratwas af01cdd
merge with master - resolve conflicts
dratwas be193c1
remove patch for rn 0.63.2
dratwas 94bab2e
update package-lock.json to resolve errors about 2 versions of react …
dratwas 2d30ae9
Update react-native to 0.64.0 stable
cameronvoell da36081
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
cameronvoell 7c61d7d
Update to React 17.0.1
youknowriad 4fbfc82
Update test utilities
youknowriad 4fe9de2
Suppress console warnings when unmounting refs
youknowriad 99338f3
Update enzyme adapter import
WunderBart 7b2aefb
Fix failing Sandbox spec
WunderBart 251eb49
Upgrade Reakit version
diegohaz 79b51c9
Add workaround for enzyme adapter unmount issue
vdwijngaert dbb4b3d
Updates snapshots to reflect changes to reakit handling popovers
vdwijngaert b3f760d
Upgrade cocoapods gem to 1.10.1
ceyhun 4b2c099
Add workaround for https://github.com/facebook/react-native/issues/31034
ceyhun 08b9427
Fix for react-native-gesture-handler, missing import
cameronvoell d1125b5
Remove top-level dependencies
ceyhun dc88a0f
Downgrade react types
ceyhun 3fdfea6
Fix Xcode shell script `Bundle React Native code and images`
ceyhun f24a982
Add workaround for another iOS build error
ceyhun 41759cf
Changes after running pod install
ceyhun da3354c
Update react-native-svg ref
ceyhun 345499b
Re-install @wordpress/react-native-editor
ceyhun 642bf9c
Changes after running pod install
ceyhun 8c0a075
Update react-native-keyboard-aware-scroll-view ref
ceyhun fbf0eb2
Update react-native-gesture-handler to fix android build issue
cameronvoell 1975429
Updating gesture-handler again after updating to 0.64.0 stable
cameronvoell 41968e2
Re-added focus/blur fix that was overridden during last update with t…
cameronvoell 146a51e
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
cameronvoell 6223288
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
cameronvoell 3a2488a
Changes after running npm install
ceyhun 05d7622
Fix hermes cli path
ceyhun ac3fe9a
Remove iOS npm cache
ceyhun c566320
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 96b2bc3
Delete all other workflows
ceyhun 141fcff
Debug CI
ceyhun 9a59ef9
Move packages under packages/react-native-editor/node_modules to top-…
ceyhun 84d9f03
Add `--no-jetifier` and `--no-packager` params to "react-native run-a…
ceyhun 1264fac
Revert "Debug CI"
ceyhun 17ce11e
Revert "Delete all other workflows"
ceyhun b829cee
Upload npm logs as artifacts
ceyhun 446881c
Add @react-native to transformIgnorePatterns in jest config
ceyhun d001423
Add patch to disable metro watch
ceyhun 69036de
fix location for NativeAnimatedHelper
cameronvoell da25174
Revert "Add patch to disable metro watch"
ceyhun 91d2382
Try force cleaning npm cache
ceyhun 41b55c5
Mock RNGestureHandlerModule manually
ceyhun d90bd09
Upgrade react-test-renderer to 17.0.1
ceyhun 9cfe46d
Install and use @wojtekmaj/enzyme-adapter-react-17
ceyhun 4ad86a4
Re-add core-js using the same version in @wordpress/babel-preset-default
ceyhun 97abd78
Add workaround for https://github.com/facebook/react-native/issues/31034
ceyhun a74d6cd
Remove temp directory from s3 for hermes / RN binaries
cameronvoell 0b1cb83
Updated s3 react-native-mirror location
cameronvoell 997ece5
Updated android binary locations
cameronvoell ac8c531
Update sleep time after aztec publish from 30 sec to 2 min
cameronvoell 12975b9
Adding s3 maven directory
cameronvoell b58d994
Remove react-native-mirror frmo gradle file
cameronvoell f2396e2
Fix lint error
ceyhun 6401f98
Updated react native libs refs
cameronvoell 8165580
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
cameronvoell c6c9344
Try npm cache verify command to fix ios CI
cameronvoell 66b9251
Set sleep time after rn-aztec publish back to 30 sec
cameronvoell a900dee
Added npm logs as artifacts for android ci job
cameronvoell b4b9333
Debug CI
ceyhun c192e97
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun f8396ed
Remove Xcode 12.5 RN patch
ceyhun c200f6d
Use same core-js version with @wordpress/babel-preset-default
ceyhun c053b3b
Try npm install
ceyhun 8a79157
Try npm install
ceyhun 0ee9712
Revert "Debug CI"
ceyhun 0a89eb0
Revert "Try npm cache verify command to fix ios CI"
ceyhun 0a6c7d1
Revert "Try force cleaning npm cache"
ceyhun 6ff84d8
Revert "Remove iOS npm cache"
ceyhun 3a701b4
Revert "Upload npm logs as artifacts"
ceyhun dd8b910
Trigger CI
ceyhun 78e9d38
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 9c21f8a
Try removing react-native-prompt-android package
ceyhun a6d201d
Remove other workflows
ceyhun 1006714
Debug CI
ceyhun 61c7e9c
Debug CI
ceyhun e209fde
Revert "Remove other workflows"
ceyhun 2e67807
Revert "Debug CI"
ceyhun 5f3d89b
Revert "Debug CI"
ceyhun cc47236
Try removing react-native-safe-area-context package
ceyhun 2efc1c8
Try deleting ~/.npm folder
ceyhun feea0ad
Revert "Try deleting ~/.npm folder"
ceyhun 4818318
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun b4d8a5c
Try node 16
ceyhun 11bb937
Revert "Try removing react-native-safe-area-context package"
ceyhun f051557
Revert "Try removing react-native-prompt-android package"
ceyhun 3f9fd0c
Revert "Try node 16"
ceyhun e8c7016
Try node 16 in every workflow
ceyhun 1b26322
Clear npm caches in all workflows
ceyhun 36918cf
Try without rm -rf ~/.npm
ceyhun 83e7d56
Disable caching ~/.npm in all workflows
ceyhun 1947595
Try node 14 and only 'rm -rf ~/.npm'
ceyhun 83a3082
Try node 14 && 'rm -rf ~/.npm' && 'npm cache clean -force'
ceyhun 98b30e4
Try node 16 && 'npm install -g npm@6' && 'rm -rf ~/.npm'
ceyhun b036973
Try node 16 && 'npm install -g npm@6' && 'npm cache clean -force' && …
ceyhun d9ccd12
Try node 16 && 'npm cache clean -force' && 'rm -rf ~/.npm' && 'npm in…
ceyhun 1dae95d
Try node 16 && 'npm cache clean -force' && 'npm install -g npm@6' && …
ceyhun abadb6a
Try 'nvm install' && 'npm cache clean -force' && 'rm -rf ~/.npm'
ceyhun 41e5fe9
Update nvm install command
ceyhun 0c26aea
Print node, npm version
ceyhun a2e6290
nvm install 16
ceyhun cd54323
Add --loglevel verbose to npm ci and install
ceyhun 2b939f0
Try default shell
ceyhun fa3b09d
Remove default shell
ceyhun 2dd9768
Try nvm with node 14
ceyhun bb5c002
Try adding back cache clean
ceyhun 5ae81f3
Try nvm, node 16, npm 6
ceyhun 2166d0c
Revert github workflow changes
ceyhun 54d4561
Disable node_modules caches
ceyhun a1b45f5
Re-create package-lock.json
ceyhun 5e9677f
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 33ee342
Revert package-lock.json to trunk
ceyhun 2b23d32
Try removing packages with package.json files that have changes
ceyhun 4e93200
Re-add packages with package.json files that have changes
ceyhun 781e403
Try npm cache verify and --loglevel verbose
ceyhun 715e5e0
Revert "Try npm cache verify and --loglevel verbose"
ceyhun 6f72d0b
Use node 12 instead of 14
ceyhun 509b4af
Revert "Use node 12 instead of 14"
ceyhun 34f5af7
Replace npm ci with npm install and add error message on git diff
ceyhun d67a0c0
Test if a package-lock.json diff is catched on npm install
ceyhun 9987bb9
Revert "Test if a package-lock.json diff is catched on npm install"
ceyhun efab1eb
Remove error message on git diff as it's already checked by 'check-lo…
ceyhun 24bb837
Convert a remaining npm ci to npm install
ceyhun e43bf68
Remove metro assets from iOS build cache
ceyhun 57d38d9
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun f3cd941
Revert "Disable node_modules caches"
ceyhun f027bdf
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 0f312b5
Merge branch 'update/react-17' into rnmobile/try/upgrade-0-64
ceyhun 3bc5f50
Fix error in templates.test after React 17 upgrade
ceyhun ea50fee
Update react-native-linear-gradient and react-native-hsv-color-picker…
ceyhun 3d7c378
Update react-native-linear-gradient and react-native-hsv-color-picker…
ceyhun 4a6ced1
Update react-native-linear-gradient version
cameronvoell 4e2d37c
Update react-native-hsv-color-picker ref
ceyhun 36fd0c6
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 2ac9950
Update to React 17.0.1
youknowriad cb718e6
Update test utilities
youknowriad c9331f5
Suppress console warnings when unmounting refs
youknowriad 17a4cb1
Update enzyme adapter import
WunderBart 15fd0f4
Fix failing Sandbox spec
WunderBart 00d1f7f
Upgrade Reakit version
diegohaz 05b9704
Add workaround for enzyme adapter unmount issue
vdwijngaert 9d69bd7
Updates snapshots to reflect changes to reakit handling popovers
vdwijngaert d3198a1
Fix error in templates.test after React 17 upgrade
ceyhun a865b92
Fix remaining e2e test failure
youknowriad 1d9a6b7
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun e3d0e7e
Bump react-native-safe-area-context to v3.2.0
hypest affca39
Bump to include build fixes for react-native-safe-area-context
hypest 0e61675
Bump react-native-safe-area-context to include using RN 0.64
hypest 6ee49b9
Bump react-native-slider to include using RN 0.64
hypest 80cdd5c
Bump react-native-get-random-values to include using RN 0.64
hypest 090c2b9
Bump react-native-masked-view to include using RN 0.64
hypest f7221cb
Bump react-native-screens to include using RN 0.64
hypest 7f5b6e1
Bump react-native-reanimated to include using RN 0.64
hypest 1ead654
Bump react-native-prompt-android to include using RN 0.64
hypest 852544b
Merge branch 'update/react-17' into rnmobile/try/upgrade-0-64
ceyhun e3e80b2
Changes to package-lock.json after running npm install
ceyhun bb219ba
Changes to Podfile.lock after running npm run native ios
ceyhun 4369752
Trigger CI
ceyhun 3e095a7
Replace setTimeout with jest.advanceTimersByTime
ceyhun 4f88e2f
Move local eslint config to top-level overrides section
ceyhun 85c4331
Replace npm install with npm ci on CI
ceyhun e8cd4af
Revert workflows that were originally using npm install
ceyhun 0d28ea3
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun 2e5c6f9
Merge branch 'trunk' into rnmobile/try/upgrade-0-64
ceyhun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,5 +39,5 @@ jobs: | |
|
||
- name: npm install, build, format and lint | ||
run: | | ||
npm ci | ||
npm install | ||
npm run test:create-block |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why is
npm install
necessary with React 0.64?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should've mentioned this in the description, will add it there shortly after.
npm ci
was throwingcb() never called!
errors randomly both on Linux and macOS on GitHub Actions. We're still not sure what's the reason.I tried various different combinations of node, npm, caching, etc. also debugging manually. Those attempts can be traced in some of these commits. Only thing that made the
cb() never called!
errors go away so far was usingnpm install
instead ofnpm ci
. I believe this might be an npm bug and hope it will be fixed with npm@7.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youknowriad and @desrosj, do you know how to make those GitHub actions work by keeping
npm ci
that should be faster?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this change is what caused the test to start passing, @desrosj made a change on trunk to improve the situation for these failures already. I think we still have some cases left but less than before.