Fix PHP notice shown when rendering a navigation link block #28999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
changed the title
talldan
changed the title
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Feb 15, 2021
|
Thanks for the catch @talldan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An undefined index PHP notice is present in the page when using a nav link block that doesn't have a
typeproperty.The standard 'Link' block doesn't seem to have a
type.How has this been tested?
Added a unit test
Manual testing steps:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: