Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed radio-control checked dot issue #28941

Closed
wants to merge 1 commit into from

Conversation

manjeet-wisetr
Copy link

@manjeet-wisetr manjeet-wisetr commented Feb 11, 2021

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 11, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @manjeet-wisetr!. In case you missed it, we'd love to have you join us in our Slack community,where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Soean
Copy link
Member

Soean commented Feb 11, 2021

Hey @manjeet-wisetr,
thanks for contributing. Can you add a description what has changed and why.
Can you also add a before/after screenshot if something visually has changed?

@manjeet-wisetr
Copy link
Author

Hello @Soean
I'm using WordPress react radio-control component, there is some CSS issue in their core styling,
check this screenshot https://prnt.sc/z321p8 (Before)
I have added box-sizing property to fix them https://prnt.sc/z324fr (After)

Base automatically changed from master to trunk March 1, 2021 15:45
@stokesman
Copy link
Contributor

Closing because this was fixed in #30670

@stokesman stokesman closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants