wp-env: Fix issue where mappings sources were not downloaded #28930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
|
I can confirm that this now works as advertised. |
noahtallen
force-pushed
the
fix/wp-env-mappings-sources
branch
from
5752c06 to
843f04d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our docs say "Several types of strings can be passed into the core, plugins, themes, and mappings fields." to describe that each can support .zip/github/local sources. However, we were never downloading "mappings" sources from git or .zip sources.
This PR begins downloading the mappings sources in the same way we download the others.
How has this been tested?
Locally, with the following .wp-env.override.json file, I tested that this directory was added to the root wordpress instance.
{ "mappings": { "theme-unit-test": "WPTT/theme-unit-test#master" } }Screenshots
Types of changes
Bug fix
Checklist: