Polish social links when inside navigation. #28836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
|
Size Change: +53 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
mkaz
reviewed
Feb 8, 2021
mkaz
requested changes
Feb 8, 2021
jasmussen
force-pushed
the
try/improve-social-links-in-nav
branch
from
017cec3 to
95256f7
Compare
|
Thank you for the review! I fixed the comment 😅
That's actually separate, and technically intended behavior (see master branch). The sibling inserter, the blue one with a line, now works vertically in addition to horizontally, and shows up between rows of horizontal child blocks when hovering the gutter. You can see this also with the Buttons block, and if #28833 lands, there too. I agree there's probably some refinement to do here, it's still fiddly and perhaps too easy to invoke. But I think it can be made to work. In any case, it should likely happen separately. |
mkaz
approved these changes
Feb 9, 2021
|
Ok, it feels like too many inserters, but as you say that is different and can be addressed later. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Social Links block, when used inside the Navigation block, is rather broken:
You can't really insert any items at all, and it fades out to suggest it's selected even when it isn't. This PR fixes that:
It:
Checklist: