Blocks: Move the logic for Template Part label to the block #28828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
gziolo
requested review from
vindl,
david-szabo97,
aristath and
Addison-Stavlo
gziolo
added
[Type] Code Quality
youknowriad
reviewed
Feb 8, 2021
|
Size Change: -58 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
david-szabo97
approved these changes
Feb 8, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #28789.
This PR removes the cyclic dependency between
@wordpres/blocksand@wordpress/core-blocksdiscovered in #28789.See related comment from @youknowriad: #28789 (comment)
Template Part block should implement
__experimentalLabelrather itself. Block API should be general and shouldn't know that Template Part block exists in the first place. It improves the implementation from #28330.How has this been tested?
CI tests pass.
Follow instructions from #28330 and ensure that everything works as before.
Types of changes
Refactoring.
Checklist: