Enqueue comment-reply script when post-comments-form block gets rendered #28826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
changed the title
|
Size Change: -266 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
I have not tested the PR yet, I wanted to add that this is the issue: #24044 |
carolinan
approved these changes
Feb 9, 2021
youknowriad
reviewed
Feb 10, 2021
youknowriad
reviewed
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All WordPress themes are required to enqueue the
comment-replyscript.They usually do this by adding code like this:
In FSE themes we should automatically enqueue the script when needed instead of requiring authors to write PHP.
Types of changes
This PR adds the script in
wp_footerwhen thepost-comments-formblock gets rendered.EDIT: Turns out
wp_enqueue_script()works.Due to the nature of blocks rendering, thewp_enqueue_script()function could not be used here, so instead of that, the PR adds the script in$wp_scripts.How has this been tested?
Tested with an FSE theme and verified that when the block exists in a page, the script gets properly enqueued in the footer.
Checklist: