Update README for SelectControl #28811
Conversation
JohnRDOrazio
requested review from
ajitbohra and
chrisvanpatten
as code owners
github-actions
bot
added
the
First-time Contributor
|
fixes issue #28812 |
| - There is a strong default option. | ||
| - There is little available space. | ||
| - The contents of the hidden part of the menu are obvious from its label and the one selected item. For example, if you have an option menu labelled “Month:” with the item “January” selected, the user might reasonably infer that the menu contains the 12 months of the year without having to look. | ||
|
|
||
| If you have a shorter list of options, or need all of the options visible to the user, consider using RadioControl instead. |
There was a problem hiding this comment.
I removed this because the way the multiselects are designed by browsers, all of the options are visible to the user, or at least will have a vertical scroll so as to scroll through the options. With the multiple attribute, there is no dropdown as in the single selection.
Even though the `multiple` attribute is foreseen as a possible attribute, the wording of the handbook seems to exclude the possibility of selecting multiple options from the list. This fix clears up the wording to allow for both single and multiple selections from the list.
|
Congratulations on your first merged pull request, @JohnRDOrazio! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Even though the
multipleattribute is foreseen as a possible attribute, the wording of the handbook seems to exclude the possibility of selecting multiple options from the list. This fix clears up the wording to allow for both single and multiple selections from the list.Types of changes
Wording of the README for the SelectControl component.