Improve performance on file access of experimental-theme.json
#28786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very unlikely the readability of the file will change during the execution time. Doing file-system requests isn't free of charge, storing the result in memory is much cheaper.
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
oandregal
approved these changes
Feb 5, 2021
oandregal
added
[Type] Performance
|
Here it is #28788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unlikely the readability of the file will change during the execution time.
Doing file-system requests isn't free of charge, storing the result in memory is much cheaper.
Description
While testing the full site editing on our internal contributor day at Yoast; we were looking at ticket #27528 when I came across this code and realized the performance potential of the change.
How has this been tested?
Running the functionality and seeing that the file is used when it's found and not used when it's not found.
Screenshots
Types of changes
Performance improvement.
Checklist: