Navigation screen: Fix failing request for menu items #28764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
tellthemachines
as code owners
|
Size Change: +94 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Feb 8, 2021
talldan
deleted the
fix/navigation-editor-malformed-menu-items-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The navigation editor seems to make a malformed request for menu items resulting in a 400 status HTTP response:
This seems to be caused by the preceding request for a menu and menu id not being resolved yet. The menu id is needed as a param in the request that's failing.
It seems like an easy enough fix to return early from the resolver for fetching menu items, since this whole process is repeated and completes successfully once a menu id is known.
I've also had to push some fixes for the isPending state of the editor, as otherwise the loading state shows forever when there are no menus with this change. This is already previously buggy, #28124 covers a proper fix.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: