Fix legacy settings tests for custom spacing #28628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
changed the title
oandregal
added
the
[Type] Automated Testing
oandregal
force-pushed
the
fix/legacy-settings-test
branch
from
d4d3c51 to
69058d3
Compare
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
I'm going to merge this one as part of fixing #28623 |
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP tests are failing because the docker image has been updated to PHP 8 but the phpunit hasn't been updated yet.
#28623 made some changes to custom spacing that made some PHP tests fail. Those failures were masked by the fact that PHP test didn't run at all.
This PR fixes those tests.
How to test
Use Try updating composer packages #28623 as a base
npm run wp-env destroynpm run wp-env startnpm run test-phpCherry-pick this PR on top:
git cherry-pick <name-of-this-pr-locally>The expected result is that tests pass.