[Navigation Link]: Add block variation matcher to display information from a found match #28626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
draganescu,
noisysocks,
talldan,
jasmussen and
kevin940726
|
This is solid! It definitely fixes #28578. Pages:
Post link:
Tag link:
👍 👍 from me — does it need a quick code sanity check? Otherwise, ship it! |
|
Size Change: +50 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Feb 2, 2021
ntsekouras
force-pushed
the
add/navigation-link-variation-matcher-function
branch
from
b7b9244 to
aa76b9b
Compare
ntsekouras
force-pushed
the
add/navigation-link-variation-matcher-function
branch
from
aa76b9b to
adfe486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #28578
This PR adds
isActivematcher function toNavigation Linkblock variations. This results in showing the matching variation information, if found, in several places like theBlockSwitchericon, Navigation List and Block Card.Testing instructions are in the issue.