Preserve input focus on arrow key in navigable container #28614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing focus on left and right arrow
6 tasks
|
Size Change: +24 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
@diegohaz knows more about this then me so I'll defer to Diego's feedback. I'm skeptical about this change, as mentioned on the related PR #25343. Arrow keys are supposed to be used for navigation between toolbar items, and I think it'd be unexpected when they suddenly don't do that, like when focus lands in an input. There's already the Template Part block, which has an input in a toolbar that doesn't work correctly. This PR results in the arrow keys being constrained to that input. This would also need to cover all the different varieties of Finally, we'd need to look at whether an input can be implemented as a |
diegohaz
reviewed
Feb 10, 2021
There was a problem hiding this comment.
This issue has been discussed in a few places already, like in #23375 (comment), where a solution has been proposed. @adamziel started implementing it on #24021. But I think in the end we agreed on fixing this at the design level by using popovers instead of inline editing on toolbars.
The problem is that it's really tricky for keyboard and screen reader users to navigate within the toolbar (which requires arrow key navigation according to the WAI-ARIA recommendations) when there are text fields in it.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue spotted by @draganescu in PR #25343 .
Users can navigate in navigable-container using arrow keys. Nevertheless, this made it impossible to use arrow keys with inputs that are placed inside the navigable-container. The proposed solution is to check if an event-target is an input or textarea and if so then do not use mechanics of changing focus with arrow keys.
How has this been tested?
Tested manually. All e2e tests are working locally.
Types of changes
Bugfix
Checklist: