Site Editor: Fix inserter can't be closed #28590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
vindl,
Copons,
jeyip and
Addison-Stavlo
TestingBehavior
Browsers
|
|
Everything looks reasonable to me! Could we add an e2e test for this? +1 after we resolve the discussion about tests. |
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
david-szabo97
force-pushed
the
fix/edit-site-inserter-cant-be-closed
branch
from
191781b to
5d819dd
Compare
|
Size Change: +35 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
There are e2e failures, but I believe that they're unrelated (and should be fixed by #28638) I'll rebase this PR when the fix is merged |
jeyip
force-pushed
the
fix/edit-site-inserter-cant-be-closed
branch
from
5d819dd to
cb02690
Compare
jeyip
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clicking the inserter button in the header toolbar keeps reopening the inserter. Fixing it by the same technique that's used in the
edit-postHow has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: