Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact info inner blocks disappearing #28569

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Contact info inner blocks disappearing #28569

merged 1 commit into from
Feb 1, 2021

Conversation

illusaen
Copy link
Contributor

@illusaen illusaen commented Jan 28, 2021

Fixes #3064.
gutenberg-mobile: #3071

Description

Contact Info inner blocks were disappearing because blockWidth wasn't set and render in BlockListItem now returns null if blockWidth is undefined or 0.

How has this been tested?

  1. Open app and insert contact info block.
  2. Verify that contact info block has email/address/phone inner blocks by default.

Screenshots

Simulator Screen Shot - iPhone 11 - 2021-01-28 at 16 28 54

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@illusaen illusaen changed the title Contact info inner blocks were disappearing because blockWidth wasn't… Contact info inner blocks disappearing Jan 28, 2021
@cameronvoell cameronvoell added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 29, 2021
@cameronvoell cameronvoell self-requested a review January 29, 2021 01:25
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is looking good. Contact Info seems to be working well after the change. I also checked testing steps from this recent related PR and they all still look good: #28489

CI Failures look unrelated, and are also occurring on other recent PRs on Gutenberg.

… set. Autosetting to layout width if not set now.
@cameronvoell cameronvoell merged commit 3e498b2 into WordPress:master Feb 1, 2021
@github-actions github-actions bot added this to the Gutenberg 10.0 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact Info Block is Missing Inner Blocks
2 participants