-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gallery block fixtures to match with gallery refactor to nested Image Blocks #28481
Closed
glendaviesnz
wants to merge
86
commits into
refactor/gallery-to-nested-image-blocks
from
refactor/gallery-to-nested-image-blocks-fixture-updates
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
Affects the Gallery Block - used to display groups of images
label
Jan 26, 2021
6 tasks
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
…ocks at the point that the block validation is run
… innerBlocks at the point that the block validation is run" This reverts commit 4d95e95.
… available at point of block validation
… gallery - with the idea that we will improve the innerblocks drag and drop in a later PR
This reverts commit 9b0abcc.
…existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR" This reverts commit cc05d60.
…transform when dragging multiple images onto the gallery
…mponent some times
…tedAttributes set
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
February 10, 2021 22:31
dfa9ec1
to
a0b9e7d
Compare
glendaviesnz
requested review from
ajlende,
ellatrix and
mkevins
as code owners
February 10, 2021 22:31
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks-fixture-updates
branch
from
February 10, 2021 23:31
9d1285a
to
6af96d3
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
February 15, 2021 20:38
8ecf39d
to
0c3dce0
Compare
26 tasks
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
5 times, most recently
from
March 1, 2021 21:51
c4dd32b
to
c72e442
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
3 times, most recently
from
March 9, 2021 20:04
f4d0ea6
to
9415d57
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
March 22, 2021 22:52
66bdda6
to
4e57fb3
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
April 12, 2021 00:39
3870131
to
d71011b
Compare
Closing as this is not needed for first merge of refactor as we are still supporting old block format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25940 for details
The test and fixture updates are on this separate PR to make review easier.