-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp-env: Expose mariadb port to host #28437
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyip
requested review from
mattwiebe,
ocean90,
vindl,
Copons,
david-szabo97,
noahtallen and
Addison-Stavlo
January 22, 2021 22:09
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
Please see the comments on #21545 for why this is not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I spin up WordPress locally with
wp-env
, I also use Sequel Ace to visualize and manage my database. The app, however, needs access to the database port from the docker MariaDB instance, which requires tinkering with thebuild-docker-compose-config.js
file.This PR intends to expose the mariaDB port to the host by default. I'm curious if anyone might be opposed or know of alternative ways to handle this.
How has this been tested?
npx wp-env start --update
to regenerate the docker compose fileTypes of changes
New feature
Checklist: