-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Performance improvements in File related controls #28224
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
@lukewalczak while working on unrelated work, I noticed that this PR removes the I presume this likely an oversight of some kind. Do you know if the intention was to keep the lowered opacity for this button when it's disabled or was there a different styling that should be applied? Either way, we likely need to fix/remove the lingering reference to a non-existing class name. Once I understand the desired outcome, I'm happy to help create a new issue to track the work. Thanks! |
Hi @dcalhoun I just happened to see this comment. I worked on the File Block so I can confirm that the opacity should be lowered when the Download button is disabled. One of the states in which it gets disabled is during the file upload process. |
Looks like the oversight from my side. If you can please create an issue for that and I will handle it asap to have the fix upcoming release ✌🏽 Thank you! |
Created a PR which moves back the style. Could you please @jd-alexander or @dcalhoun do a testing and reviewing? |
@jd-alexander @lukewalczak thanks for the info. #28706 captures the issue. I will check out the PR branch shortly. |
Merge after
Video
PR: #28220Description
Part of: #28196
Contains changes only related to the
File
block and controls available within block settings and inherit changes fromVideo
PR.SelectControl
ToggleControl
ToggleControl
TextControl
How has this been tested?
Test manually
File
block on web and mobile.You can paste the snippet to have
File
block filled:or
File
block and attach fileExpect everything works correctly
Screenshots
RESULTS
1. pressing copy url button
Types of changes
Performance improvements
Checklist: